This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Adding RenderSectionAsync to support async sections #1228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
changed the title
pranavkm
force-pushed
the
AsyncSections
branch
from
c552a71 to
2e30606
Compare
pranavkm
changed the title
pranavkm
changed the title
| /// <returns>A <see cref="Task{TResult}"/> that represents the results of rendering.</returns> | ||
| /// <exception cref="InvalidOperationException">if <paramref name="required"/> is <c>true</c> and the section | ||
| /// was not registered using the <c>@section</c> in the Razor page.</exception> | ||
| public async Task<object> RenderSectionAsync([NotNull] string name, bool required) |
There was a problem hiding this comment.
Why do we have to use object here instead of the actual type?
There was a problem hiding this comment.
Temporary for beta. We need to return something for the rendering to succeed. Post beta, we need to address aspnet/Razor#85 so that this can return an AsyncHelperResult which gets evaluated by WriteAsync
* Adding unit tests to cover RenderSectionAsync
pranavkm
force-pushed
the
AsyncSections
branch
from
2e30606 to
a4b3799
Compare
|
Updated to use HtmlString |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845