-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add IHtmlGenerator
and TextAreaTagHelper
#1309
Conversation
IHtmlGenerator
and its default implementationIHtmlGenerator
and its default implementation
/cc @NTaylorMullen
|
d948242
to
b68fae9
Compare
045a127
to
2535a4b
Compare
…scussion - lots of new comments in Create.cshtml
2535a4b
to
d1bf693
Compare
👍 should I just inject the |
|
@@ -0,0 +1,15 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, add this project to the Mvc.NoFun.sln 😄 VS exploding at home more than I like haha
@natemcmaster updated. haven't added project.json version yet but have added anti-forgery. /cc @harshgMSFT @GrabYourPitchforks please take a quick look at change to |
- part of #1243 (kind-of) - mostly copied from `HtmlHelper` but refactored to - consistently take a `ViewContext` parameter and return a `TagBuilder` - provide `GenerateActionLink()` and `GenerateRouteLink()` - provide a separate `GenerateHiddenForCheckBox()`, allowing `GenerateCheckBox()` to return a `TagBuilder` - `GenerateForm()`'s `method` parameter is a `string`, not `FormMethod` nits: format document, consistent line wrapping, variable name changes, ...
I have no concerns re: the signature change. |
82cce78
to
e1f28eb
Compare
- add version to Microsoft.AspNet.Mvc.TagHelpers/project.json - also turn on warnings-as-errors
IHtmlGenerator
and its default implementationIHtmlGenerator
and TextAreaTagHelper
- enable MVC tag helpers in TagHelperSample.Web - also fix a couple of issues in TagHelperSample.Web
89b19e2
to
42a508d
Compare
|
Will open a new PR to complete this work later today... |
<textarea/>
and other MVC tag helpers #1243 (kind-of) and most of Tag Helpers: create a new project in the MVC repository to hold<textarea/>
and other MVC tag helpers #1243DefaultHtmlGenerator
mostly copied fromHtmlHelper
but refactored toViewContext
parameter and return aTagBuilder
GenerateActionLink()
andGenerateRouteLink()
GenerateHiddenForCheckBox()
, allowingGenerateCheckBox()
to return aTagBuilder
GenerateForm()
'smethod
parameter is astring
, notFormMethod
TextAreaTagHelper