This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Add ValidationSummaryTagHelper. #1340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
4473a33 to
de8706e
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
ff71b0b to
a8a3ccb
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
de8706e to
108a0ba
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
a8a3ccb to
7dd31d5
Compare
| [ContentBehavior(ContentBehavior.Append)] | ||
| public class ValidationSummaryTagHelper : TagHelper | ||
| { | ||
| private static readonly bool DefaultModelErrorsOnlyBehavior = false; |
|
⌚ |
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
108a0ba to
af0ac42
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
7dd31d5 to
b3d6569
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
af0ac42 to
0708aef
Compare
NTaylorMullen
changed the title
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
2 times, most recently
from
c490007 to
c8615e9
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
0708aef to
a33aa3e
Compare
|
Addressed code review comments to the exception of the one comment with differing opinions 😄 |
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
a33aa3e to
342362c
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
c8615e9 to
6e4dcb6
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
342362c to
8a24434
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
6e4dcb6 to
65d5145
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
8a24434 to
673a9ea
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
65d5145 to
3a0403c
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
673a9ea to
3ff67ca
Compare
| Assert.Equal("div", output.TagName); | ||
| Assert.Empty(output.Attributes); | ||
|
|
||
| if (!validationSummary.Equals("None", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
split into two tests rather than conditionalizing the Asserts
|
⌚ |
|
Addressed code review comments. |
|
Update TagHelper sample to use new validation-summary format. |
NTaylorMullen
force-pushed
the
TagHelpers_ValidationMessage
branch
from
1cf6935 to
0d4d7c6
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
de98414 to
99f8720
Compare
|
|
||
| // TODO: Change to ValidationSummary enum once https://github.com/aspnet/Razor/issues/196 has been completed. | ||
| /// <summary> | ||
| /// Acceptable values are defined by the <see cref="ValidationSummary"/> enum. |
There was a problem hiding this comment.
good second sentence in this <summary/>. restore first sentence from an earlier iteration to describe that this property is for.
|
⌚ just for a quick look at doc comments in next iteration |
| Resources.FormatValidationSummaryTagHelper_InvalidValidationSummaryValue( | ||
| "validation-summary", | ||
| ValidationSummaryValue, | ||
| ValidationSummary.All.ToString(), |
There was a problem hiding this comment.
Shouldn't have to do ToString(), the string.Format would do that for you.
|
|
once
|
Updated. |
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
8edcc0c to
3aa9323
Compare
| @@ -126,4 +126,7 @@ | |||
| <data name="FormTagHelper_CannotDetermineAction" xml:space="preserve"> | |||
| <value>Cannot determine an {1} for {0}. A {0} with a URL-based {1} must not have attributes starting with {3} or a {2} attribute.</value> | |||
| </data> | |||
| <data name="ValidationSummaryTagHelper_InvalidValidationSummaryValue" xml:space="preserve"> | |||
| <value>Cannot parse {0} value '{1}'. Acceptable values are '{2}', '{3}' and '{4}'.</value> | |||
There was a problem hiding this comment.
nit: passing your usual rule back 😸 add "for {2}" just before the first period
There was a problem hiding this comment.
quote current {0} as well -> '{0}' (though that should probably become {1} and so on
|
|
- Tested ValidationSummaryTagHelper behavior. - Updated sample to utilize new ValidationSummaryTagHelper format. #1251
NTaylorMullen
force-pushed
the
TagHelpers_ValidationSummary
branch
from
3aa9323 to
ba111a4
Compare
|
Done in TagHelpersFeature via ba111a4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1251