This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Update HtmlHelper to use IHtmlGenerator
#1348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
force-pushed
the
TagHelpersFeature
branch
from
ca63b8b to
511285d
Compare
dougbu
force-pushed
the
ihtmlgenerator.in.htmlhelper
branch
from
0647d8c to
2ed038a
Compare
|
rebased on latest TagHelperFeature, which I rebased on origin/dev just a bit ago |
|
/cc @NTaylorMullen or @pranavkm and @sornaks (who should have some familiarity with the changed |
| return HtmlString.Empty; | ||
| } | ||
|
|
||
| return tagBuilder.ToHtmlString(TagRenderMode.Normal); |
There was a problem hiding this comment.
nit: if you think it's cleaner you could do across the board:
return tagBuilder?.ToHtmlString(TagRenderMode.Normal) ?? HtmlString.Empty;There was a problem hiding this comment.
definitely less clean. also uselessly null-checks the ToHtmlString() return value.
|
Holy massive change. I have to say it does make me a bit nervous having suchhh a large change set without #453 in. |
|
we do have a few tests that cover the helpers. I've also checked the MVC sample out... |
| var byteArrayValue = value as byte[]; | ||
| if (byteArrayValue != null) | ||
| var tagBuilder = | ||
| _htmlGenerator.GenerateHidden(ViewContext, metadata, name, value, useViewData, htmlAttributes); |
There was a problem hiding this comment.
Could you format it so that the parameters are in separate lines (like the MvcForm) above? Makes it seem more consistent
…scussion - lots of new comments in Create.cshtml
- part of #1243 (kind-of) - mostly copied from `HtmlHelper` but refactored to - consistently take a `ViewContext` parameter and return a `TagBuilder` - provide `GenerateActionLink()` and `GenerateRouteLink()` - provide a separate `GenerateHiddenForCheckBox()`, allowing `GenerateCheckBox()` to return a `TagBuilder` - `GenerateForm()`'s `method` parameter is a `string`, not `FormMethod` nits: format document, consistent line wrapping, variable name changes, ...
- add version to Microsoft.AspNet.Mvc.TagHelpers/project.json - also turn on warnings-as-errors
- enable MVC tag helpers in TagHelperSample.Web - also fix a couple of issues in TagHelperSample.Web
dougbu
force-pushed
the
TagHelpersFeature
branch
from
511285d to
ce38d26
Compare
dougbu
force-pushed
the
ihtmlgenerator.in.htmlhelper
branch
from
2ed038a to
d576aec
Compare
|
|
- make a few more methods available as `internal static` in `DefaultHtmlGenerator` - remove `IHtmlGenerator.GenerateOption()`; now `internal static` nits: - add `IHtmlGenerator.IdAttributeDotReplacement` - move `DefaultHtmlGenerator.IdAttributeDotReplacement` after constructor - move `HtmlHelper.ActionLink()` below static methods - move newly-`internal` methods together in `DefaultHtmlGenerator` - correct placement of `DefaultHtmlGenerator.GetValidationAttributes()` comment
dougbu
force-pushed
the
ihtmlgenerator.in.htmlhelper
branch
from
3a30e87 to
de5884f
Compare
dougbu
force-pushed
the
TagHelpersFeature
branch
from
ce38d26 to
50f7748
Compare
|
Checked into TagHelperFeature w/ commit 50f7748 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<textarea/>and other MVC tag helpers #1243; previous commit did not get everything usingIHtmlGeneratorinternal staticinDefaultHtmlGeneratorIHtmlGenerator.GenerateOption(); nowinternal staticnits:
IHtmlGenerator.IdAttributeDotReplacementDefaultHtmlGenerator.IdAttributeDotReplacementafter constructorHtmlHelper.ActionLink()below static methodsinternalmethods together inDefaultHtmlGeneratorDefaultHtmlGenerator.GetValidationAttributes()comment