This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Add extensions for TagHelperOutput to copy from TagBuilder. #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static IEnumerable<KeyValuePair<string, string>> PullPrefixedAttributes( | ||
| this TagHelperOutput tagHelperOutput, string prefix) | ||
| { | ||
| // TODO: We will not need this method once https://github.com/aspnet/Razor/issues/89 is completed. |
There was a problem hiding this comment.
- why does this name remain unchanged?
- FYI I kind-of liked @yishaigalatzer's suggestion to split this in two -- say
FindPrefixedAttributes()andRemovePrefixedAttributes()(or perhapsRemoveRange()if Linq doesn't provide that as anIEnumerableextension)
|
NTaylorMullen
force-pushed
the
TagHelpersFeature
branch
from
6a61a8f to
4208c8f
Compare
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
199a8e2 to
d3af121
Compare
|
Addressed code review comments. |
| TagHelperContext context) | ||
| { | ||
| // We look for the original attribute so we can restore the exact attribute name the user typed. | ||
| var entry = context.AllAttributes.Single(attribute => |
There was a problem hiding this comment.
If you don't care about throwing an exception if there's more than one item (and you shouldn't be relying on Singles exception message anyway), use First() instead.
There was a problem hiding this comment.
Also, what's the type of AllAttributes?
There was a problem hiding this comment.
AllAttributes = Dictionary<string, object>
|
|
once
|
Addressed pranav's comments. |
| public static class TagHelperOutputExtensions | ||
| { | ||
| /// <summary> | ||
| /// Copies a user provided attribute from <paramref name="context"/>'s |
|
⌚ let's discuss |
|
@dougbu After addressing nits am I got to ship since we discussed the one |
|
Addressed code review comments. |
|
|
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
e127da2 to
b7a38c3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag Helpers: Add TagHelperOutput extension methods to copy from TagBuilder #1319