This repository was archived by the owner on Dec 14, 2018. It is now read-only.
* Remove support for updateable precompiled views. #2917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +13,9 @@ public class Startup | |||
| public void ConfigureServices(IServiceCollection services) | |||
| { | |||
| // Add MVC services to the services container | |||
| services.AddMvc(); | |||
| services | |||
There was a problem hiding this comment.
@rynowak what's the best way to do this?
There was a problem hiding this comment.
For now, make an extension method on IMvcBuilder and on IServiceCollection. The IServiceCollection part will go away soon.
|
😻 |
| IAssemblyLoadContextAccessor loadContextAccessor, | ||
| IOptions<RazorViewEngineOptions> optionsAccessor) | ||
| : this(razorFileInfoCollections, | ||
| loadContextAccessor.GetLoadContext(typeof(CompilerCache).GetTypeInfo().Assembly), |
There was a problem hiding this comment.
would help readability to put this back in a private field. loadContextAccessor.GetLoadContext(RazorHostAssembly) > current
|
⌚ |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file system.
Fixes #2462 and fixes #2796.
Partially addresses #2551