This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Use MvcTextFixture as much as possible
#3133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle `ConfigureServices()` methods that are not `void` - ensure server is initialized with consistent `CurrentCulture` and `CurrentUICulture` - add `FilteredDefaultAssemblyProviderFixture<TStartup>` and `MvcEncodedTestFixture<TStartup>` - add `MvcTextFixture.AddAdditionalServices()` extension point supporting these - do not expose the `TestServer`; an anti-pattern for tests to manipulate the server - update class names to match containing files - use existing `TestApplicationEnvironment` - apply some `MvcTestFixture` improvements to the shared `TestApplicationEnvironment` class
- change `ConfigureServices()` support to use the same approach
- remove use of `HttpClient.DefaultRequestHeaders`; any client change affects other tests - remove use of `RequestBuilder` class; creates a per-test `HttpClient` and access requires the `TestServer` - updated a few expectations because `CommonTestEncoder` does JavaScript a bit differently - "JavaScriptEncode[[...]]" -> "JavaScriptStringEncode[[...]]" - side benefit: xUnit reports functional tests execute for only ~12.4s; was >30s before this change nits: - touched-up some leftover `_app` &c declarations to be more explicit and minimize `using`s - moved statements into correct sections of methods in `RoutingTests` - removed `TestLoggerFactory` and related classes from `TagHelperSampleTest`
|
/cc @pranavkm (note we only went though the first commit last week) |
| } | ||
| } | ||
|
|
||
| private class TestDisposable : IDisposable | ||
| [Theory] | ||
| [MemberData(nameof(PathData))] |
There was a problem hiding this comment.
Two overlapping changes aren't easy to read here:
- don't need
TestLoggerFactoryplusNullLoggerFactory Home_Pages_ReturnSuccess()should never have been a single test with a loop in it
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOExceptions using MVC with Core CLR on Linux #3066TestServer->PhysicalFileProvider->FileSystemWatchercount enough to run with Core CLR on LinuxHttpClient.DefaultRequestHeaders; any client change affects other testsRequestBuilderclass; creates a per-testHttpClientand requires theTestServerCommonTestEncoderdoes JavaScript a bit differentlynits:
_app&c declarations to be more explicit and minimizeusingsRoutingTestsTestLoggerFactoryand related classes fromTagHelperSampleTest