This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Re-enable functional tests on full .NET Framework #5877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #5873 - creating an EXE for the test project seems to work around #5873 - also avoids dotnet/sdk#926 when building in Visual Studio nit: clean up duplicate test data
|
FYI I went back and forth between trying to create a minimal repro and looking for a workaround. Found the workaround first. |
pranavkm
approved these changes
Mar 2, 2017
| <PackageTargetFallback>$(PackageTargetFallback);portable-net451+win8</PackageTargetFallback> | ||
| <TargetFrameworks>netcoreapp1.1;net452</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">netcoreapp1.1</TargetFrameworks> | ||
| <PackageTargetFallback Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">$(PackageTargetFallback);portable-net451+win8</PackageTargetFallback> |
There was a problem hiding this comment.
"'$(OS)' != 'Windows_NT'" versus " '$(TargetFramework)' == 'netcoreapp1.1' ". We should pick one spacing
There was a problem hiding this comment.
🙈 I find conditions easier to read with more spaces. But, no need for an engineering guideline / principle / law here. As long as people aren't adding or removing spaces in otherwise-untouched code, author's discretion to the max.
| Generate an EXE to take advantage of Microsoft.NET.RuntimeIdentifierInference.targets special cases. This works | ||
| around #5873. Also avoids dotnet/sdk#926 when building with msbuild.exe e.g. in Visual Studio. | ||
| --> | ||
| <OutputType Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">EXE</OutputType> |
There was a problem hiding this comment.
Do we need to file an SDK bug for this?
There was a problem hiding this comment.
We need a bug somewhere. I need to minimize my repro project first though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nit: clean up duplicate test data