This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Disable API check for newly added packages #6563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Jul 19, 2017
| @@ -8,6 +8,7 @@ | |||
| <NoWarn>$(NoWarn);CS1591</NoWarn> | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| <PackageTags>aspnetcore;aspnetcoremvc;cshtml;razor</PackageTags> | |||
| <EnableApiCheck>false</EnableApiCheck> | |||
There was a problem hiding this comment.
We should have an empty baseline rather then disabling API check. Then when we go to update all of the baselines the empty one will become full
There was a problem hiding this comment.
Oh right, that's what we decided to do. I totally forgot.
There was a problem hiding this comment.
It takes two people to be bad. One to be do something bad, and the other one to sign off on the PR
pranavkm
force-pushed
the
prkrishn/disable-api-check
branch
from
dd0bbcd to
1f40681
Compare
pranavkm
force-pushed
the
prkrishn/disable-api-check
branch
from
1f40681 to
c56f2c0
Compare
|
🆙 📅 |
Eilon
approved these changes
Jul 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.