Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Allow "page" route parameter to be used in Mvc controllers #6704

Closed
wants to merge 33 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
337eb18
Merge branch 'rel/2.0.0' into dev
pranavkm Jul 10, 2017
7060549
Merge branch 'rel/2.0.0' into dev
pranavkm Jul 10, 2017
8226e84
Merge remote-tracking branch 'origin/rel/2.0.0' into dev
javiercn Jul 10, 2017
b37f4ab
Skip first time experience on Appveyor
ryanbrandenburg Jul 7, 2017
06b6e90
Merge branch 'rel/2.0.0' into dev
javiercn Jul 10, 2017
9c33cc2
Merge remote-tracking branch 'origin/rel/2.0.0' into dev
javiercn Jul 11, 2017
641bff9
Merge branch 'cache-tag-helpers' into dev
javiercn Jul 11, 2017
068c91d
Merge remote-tracking branch 'origin/rel/2.0.0' into dev
mikeharder Jul 13, 2017
1022bed
Merge pull request #6541 from aspnet/rel/2.0.0
mikeharder Jul 13, 2017
1e7c38f
Merge pull request #6553 from aspnet/rel/2.0.0
pranavkm Jul 14, 2017
1810925
Add _ViewStart and _ViewImports to embedded view test
pranavkm Jul 11, 2017
d79a4ff
Merge branch 'rel/2.0.0' into dev
rynowak Jul 14, 2017
b879557
Increase wait timeouts for flaky tests (#6548) (#6556)
pranavkm Jul 17, 2017
0c01ba5
Merge pull request #6561 from aspnet/rel/2.0.0
pranavkm Jul 18, 2017
f6e620d
Merge pull request #6566 from aspnet/rel/2.0.0
pranavkm Jul 19, 2017
1b69320
Merge pull request #6572 from aspnet/rel/2.0.0
mikeharder Jul 20, 2017
6eba0e2
Merge pull request #6578 from aspnet/rel/2.0.0
pranavkm Jul 21, 2017
8ab361a
Merge pull request #6582 from aspnet/rel/2.0.0
pranavkm Jul 21, 2017
80bae28
2.0.0-rtm to 2.1.0-preview1
ryanbrandenburg Jul 21, 2017
6c7d22f
Cleanup MVC Sandbox
javiercn Jul 24, 2017
96e9b8d
Set AspNetCoreVersion
ryanbrandenburg Jul 25, 2017
b00c13a
Updating to InternalAspNetCoreSdkVersion 2.1.1-*
pranavkm Jul 25, 2017
8e1a337
Update bootstrappers to use the compiled version of KoreBuild
Jul 25, 2017
16f2356
Fix syntax warning when running build.sh on older versions of bash
Jul 26, 2017
8ebc761
Update __get_remote_file logic
JunTaoLuo Aug 2, 2017
b3fe473
Ensure fallback to curl after failed wget
JunTaoLuo Aug 2, 2017
eb5c23e
Parse LanguageVersion correctly
pranavkm Aug 1, 2017
5fee1ca
Merge pull request #6655 from aspnet/rel/2.0.0
pranavkm Aug 14, 2017
b43b244
Use Directory.Build.props/targets
Aug 16, 2017
3a710c3
Upgrade to xunit 2.3.0-beta4
natemcmaster Aug 17, 2017
900a5c7
Add support for ResponseCache in Razor Pages
pranavkm Aug 3, 2017
843a97f
Allow "page" route parameter to be used in Mvc controllers
pranavkm Aug 24, 2017
4d97626
Changes per PR comments
pranavkm Aug 24, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion appveyor.yml → .appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
init:
init:
- git config --global core.autocrlf true
branches:
only:
Expand All @@ -10,6 +10,10 @@ branches:
build_script:
- ps: .\build.ps1
clone_depth: 1
environment:
global:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
DOTNET_CLI_TELEMETRY_OPTOUT: 1
test: off
deploy: off
os: Visual Studio 2017
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ node_modules
*.orig
.vscode/
global.json
BenchmarkDotNet.Artifacts/
BenchmarkDotNet.Artifacts/
korebuild-lock.txt
10 changes: 3 additions & 7 deletions build/common.props → Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
<Project>
<Import Project="dependencies.props" />
<Import Project="..\version.props" />
<Import Project="build\dependencies.props" />
<Import Project="version.xml" />

<PropertyGroup>
<Product>Microsoft ASP.NET Core MVC</Product>
<RepositoryUrl>https://github.com/aspnet/Mvc</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)Key.snk</AssemblyOriginatorKeyFile>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)build\Key.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
<PublicSign Condition="'$(OS)' != 'Windows_NT'">true</PublicSign>
<VersionSuffix Condition="'$(VersionSuffix)'!='' AND '$(BuildNumber)' != ''">$(VersionSuffix)-$(BuildNumber)</VersionSuffix>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Internal.AspNetCore.Sdk" Version="$(InternalAspNetCoreSdkVersion)" PrivateAssets="All" />
</ItemGroup>

</Project>
2 changes: 2 additions & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<Project>
</Project>
33 changes: 32 additions & 1 deletion Mvc.NoFun.sln
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.26228.9
VisualStudioVersion = 15.0.26814.0
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{DAAE4C74-D06F-4874-A166-33305D2643CE}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{32285FA4-6B46-4D6B-A840-2B13E4C8B58E}"
ProjectSection(SolutionItems) = preProject
src\Directory.Build.props = src\Directory.Build.props
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{3BA657BF-28B1-42DA-B5B0-1C4601FCF7B1}"
ProjectSection(SolutionItems) = preProject
test\Directory.Build.props = test\Directory.Build.props
test\Directory.Build.targets = test\Directory.Build.targets
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc", "src\Microsoft.AspNetCore.Mvc\Microsoft.AspNetCore.Mvc.csproj", "{079EFA1F-0B0A-4853-B27B-5780D111CD85}"
EndProject
Expand Down Expand Up @@ -74,6 +81,27 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Ra
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Performance", "test\Microsoft.AspNetCore.Mvc.Performance\Microsoft.AspNetCore.Mvc.Performance.csproj", "{28D4DA20-6E13-47F9-80AE-D6AA7699CC35}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{4E1795C3-60C5-4AD2-A15F-93F6CE8FAD36}"
ProjectSection(SolutionItems) = preProject
.appveyor.yml = .appveyor.yml
.editorconfig = .editorconfig
.gitattributes = .gitattributes
.gitignore = .gitignore
.travis.yml = .travis.yml
build.cmd = build.cmd
build.ps1 = build.ps1
build.sh = build.sh
CONTRIBUTING.md = CONTRIBUTING.md
Directory.Build.props = Directory.Build.props
Directory.Build.targets = Directory.Build.targets
LICENSE.txt = LICENSE.txt
NuGet.config = NuGet.config
NuGetPackageVerifier.json = NuGetPackageVerifier.json
README.md = README.md
Settings.StyleCop = Settings.StyleCop
version.xml = version.xml
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -499,4 +527,7 @@ Global
{0AB46520-F441-4E01-B444-08F4D23F8B1B} = {3BA657BF-28B1-42DA-B5B0-1C4601FCF7B1}
{28D4DA20-6E13-47F9-80AE-D6AA7699CC35} = {3BA657BF-28B1-42DA-B5B0-1C4601FCF7B1}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {D003597F-372F-4068-A2F0-353BE3C3B39A}
EndGlobalSection
EndGlobal
34 changes: 33 additions & 1 deletion Mvc.sln
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.26615.0
VisualStudioVersion = 15.0.26814.0
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{DAAE4C74-D06F-4874-A166-33305D2643CE}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{32285FA4-6B46-4D6B-A840-2B13E4C8B58E}"
ProjectSection(SolutionItems) = preProject
src\Directory.Build.props = src\Directory.Build.props
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{3BA657BF-28B1-42DA-B5B0-1C4601FCF7B1}"
ProjectSection(SolutionItems) = preProject
test\Directory.Build.props = test\Directory.Build.props
test\Directory.Build.targets = test\Directory.Build.targets
test\MvcTests.ruleset = test\MvcTests.ruleset
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc", "src\Microsoft.AspNetCore.Mvc\Microsoft.AspNetCore.Mvc.csproj", "{079EFA1F-0B0A-4853-B27B-5780D111CD85}"
EndProject
Expand All @@ -19,6 +27,9 @@ EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Core.Test", "test\Microsoft.AspNetCore.Mvc.Core.Test\Microsoft.AspNetCore.Mvc.Core.Test.csproj", "{A8AA326E-8EE8-4F11-B750-23028E0949D7}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "WebSites", "WebSites", "{16703B76-C9F7-4C75-AE6C-53D92E308E3C}"
ProjectSection(SolutionItems) = preProject
test\WebSites\Directory.Build.targets = test\WebSites\Directory.Build.targets
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.FunctionalTests", "test\Microsoft.AspNetCore.Mvc.FunctionalTests\Microsoft.AspNetCore.Mvc.FunctionalTests.csproj", "{323D0C04-B518-4A8F-8A8E-3546AD153D34}"
EndProject
Expand Down Expand Up @@ -122,6 +133,27 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Pe
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Testing", "src\Microsoft.AspNetCore.Mvc.Testing\Microsoft.AspNetCore.Mvc.Testing.csproj", "{7500B228-1769-4CFB-A571-3DFAC6678A06}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{631720EE-11CC-41C9-9819-441417ECBEAA}"
ProjectSection(SolutionItems) = preProject
.appveyor.yml = .appveyor.yml
.editorconfig = .editorconfig
.gitattributes = .gitattributes
.gitignore = .gitignore
.travis.yml = .travis.yml
build.cmd = build.cmd
build.ps1 = build.ps1
build.sh = build.sh
CONTRIBUTING.md = CONTRIBUTING.md
Directory.Build.props = Directory.Build.props
Directory.Build.targets = Directory.Build.targets
LICENSE.txt = LICENSE.txt
NuGet.config = NuGet.config
NuGetPackageVerifier.json = NuGetPackageVerifier.json
README.md = README.md
Settings.StyleCop = Settings.StyleCop
version.xml = version.xml
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down
2 changes: 1 addition & 1 deletion NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<configuration>
<packageSources>
<clear />
<add key="AspNetCore" value="https://dotnet.myget.org/F/aspnetcore-ci-release/api/v3/index.json" />
<add key="AspNetCore" value="https://dotnet.myget.org/F/aspnetcore-ci-dev/api/v3/index.json" />
<add key="AspNetCoreTools" value="https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json" />
<add key="NuGet" value="https://api.nuget.org/v3/index.json" />
</packageSources>
Expand Down
2 changes: 1 addition & 1 deletion build.cmd
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
@ECHO OFF
PowerShell -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = '';& '%~dp0build.ps1' %*; exit $LASTEXITCODE"
PowerShell -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = '';& '%~dp0build.ps1' %*; exit $LASTEXITCODE"
Loading