This repository was archived by the owner on Dec 14, 2018. It is now read-only.
React to the deprecation of Microsoft.AspNetCore.All #8751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Nov 21, 2018
| // it depends on Microsoft.AspNetCore.Mvc even though it does. Explicitly list it so that referencing this runtime causes | ||
| // assembly discovery to work correctly. | ||
| "Microsoft.AspNetCore.All", | ||
| "Microsoft.AspNetCore.App", |
There was a problem hiding this comment.
I think app did not have the same problem as All, but this is fine
There was a problem hiding this comment.
For context: here is what the deps.json file looks like now: https://gist.githubusercontent.com/natemcmaster/928c1973a136e7c3690f0ac628873a1d/raw/50a0a387e45a3878e114ef90bc90ab82a57dbee7/webapp1.deps.json.
If I understand right, this section of code is looking for dependencies. Microsoft.AspNetCore.Mvc won't appear as in "dependencies" or "libraries" anymore.
".NETCoreApp,Version=v3.0": {
"webapp1/1.0.0": {
"dependencies": {
"Microsoft.AspNetCore.App": "3.0.0-preview-001",
"Microsoft.NETCore.App": "3.0.0-preview-27113-06"
},
"runtime": {
"webapp1.dll": {}
},
"compile": {
"webapp1.dll": {}
}
},
"Microsoft.AspNetCore.App/3.0.0-preview-001": {
"compile": {
// ... list of ref assemblies here
"ref/netcoreapp3.0/Microsoft.AspNetCore.Mvc.dll": {},
}
},
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/aspnetcore#4175