This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Remove runtime compilation from MVC.Razor #8755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
suggested changes
Nov 21, 2018
There was a problem hiding this comment.
- should remove
CompiledViewDescriptor.IsPrecompiledproperty - where is
RazorProjectFileSystemstill used after this cleanup? that should be removed if possible - file an issue to remove
RazorPageDocumentClassifierPassfrom Razor if that's now possible or use that class (as before) instead ofconsts that duplicate values
src/Microsoft.AspNetCore.Mvc.Razor/Compilation/RazorViewCompiler.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| var basePath = "/"; | ||
| Debug.Assert(!string.IsNullOrEmpty(path)); |
| private readonly DiagnosticListener _diagnosticListener; | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="RazorViewEngine" />. | ||
| /// Initializes a new instance of the RazorViewEngine |
...osoft.AspNetCore.Mvc.RazorPages/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs
Show resolved
Hide resolved
test/Microsoft.AspNetCore.Mvc.RazorPages.Test/Infrastructure/PageActionInvokerProviderTest.cs
Show resolved
Hide resolved
pranavkm
commented
Nov 22, 2018
|
🆙 📅 |
pranavkm
force-pushed
the
prkrishn/no-runtime-compilation
branch
from
0a977d8 to
fe1f9fb
Compare
dougbu
approved these changes
Nov 22, 2018
test/Microsoft.AspNetCore.Mvc.RazorPages.Test/Infrastructure/PageActionInvokerProviderTest.cs
Show resolved
Hide resolved
|
🆙 📅 |
This was referenced Nov 22, 2018
natemcmaster
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.