-
Notifications
You must be signed in to change notification settings - Fork 16
Test failure: PrecompiledAssembliesUseSameStrongNameAsApplication #292
Comments
Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:
This comment was made automatically. If there is a problem contact ryanbrandenburg. |
Precompilation_WorksForSimpleApps failed with about the same error on 2.1. This comment was made automatically. If there is a problem contact ryanbrandenburg. |
Publish_HasNoPrecompilation failed with about the same error on 2.1. This comment was made automatically. If there is a problem contact ryanbrandenburg. |
Is 2.1 still open for test specific changes? I was planning on skipping these. |
Yes it is, with shiproom notification ("tell mode"). |
Publish_HasNoPrecompilation failed with about the same error on 2.1. This comment was made automatically. If there is a problem contact ryanbrandenburg. |
Precompilation_WorksForSimpleApps failed with about the same error on 2.1. This comment was made automatically. If there is a problem contact ryanbrandenburg. |
@pranavkm any updates on this? Are the new failures a new problem in 2.1 flakiness? |
Yup. They're all primarily issues with port acquisition, perhaps because a different process is still running:
I'll ask around to see if what other repos did something to fix this sort of issue. |
I think @mikeharder is good at acquiring ports. If we have hard coded ports that should definitely fixed. |
Spoke to @Tratcher - looks like they made some changes in 2.2 to make this more reliable: https://github.com/aspnet/Hosting/blob/81383bba8052d018771b8e17c2bc73fc872729fd/src/Microsoft.AspNetCore.Server.IntegrationTesting/Common/TestUriHelper.cs#L26-L33. Should be ok since this is test only and doesn't require cross-repo api changes. |
Fix checked in. Will keep this issue open for a week if the problem persists. |
This test fails occasionally with the following error:
Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
This test failed on 2.1.
CC @Eilon (because the bot doesn't know who else to pick)
This issue was made automatically. If there is a problem contact ryanbrandenburg.
The text was updated successfully, but these errors were encountered: