Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Change SelfHostDeployer to use dynamic ports by default (#1383) #1551

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Change SelfHostDeployer to use dynamic ports by default (#1383) #1551

merged 1 commit into from
Sep 19, 2018

Conversation

pranavkm
Copy link
Contributor

@mikeharder @pranavkm
Change SelfHostDeployer to use dynamic ports by default (#1383)
cda079a 
* Should significantly reduce flaky test failures due to AddressInUse exceptions
* Addresses #1296
@pranavkm pranavkm requested a review from Tratcher September 19, 2018 18:27
@pranavkm
Copy link
Contributor Author

Porting to 2.1 to improve test reliability. See aspnet/MvcPrecompilation#292

@pranavkm
Copy link
Contributor Author

PR: https://github.com/aspnet/Hosting/pull/1383/files

@pranavkm
Copy link
Contributor Author

@mkArtakMSFT could you do a shiproom notification for this? Change is in the 2.1 branch and this is a change in non-shipping test only package that improves stability.

@pranavkm pranavkm merged commit 3f7ee33 into release/2.1 Sep 19, 2018
@pranavkm pranavkm deleted the prkrishn/use-port0 branch September 19, 2018 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@mikeharder mikeharder mikeharder approved these changes

Assignees

@mikeharder mikeharder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @Tratcher @mikeharder