This repository was archived by the owner on Sep 24, 2019. It is now read-only.
Add directive attribute support. #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `TagHelperDescriptorJsonConverter` to match what is in Razor. - Added the new completion item provider APIs to our list of services. - Created a new `Completion` namespace to hold off of Razor's various completion pieces. - Added a new completion item provider to provide `@...` when in a directive attribute compatible area when no text has been typed. - Partially moved the existing completion system over to `AttributeCompletionDescription`. There's more work that needs to be done here to be able to delete Razor.VSCode's description info types in favor of Razor's. - Expanded the completion endpoint to understand `Directive`s, `DirectiveAttribute`s and `DirectiveAttributeParameter`s. - Updated the `RazorDiagnosticPublisher` to handle cases when the underlying `RazorCodeDocument` has been garbage collected. Razor no longer caches these objects. - Added and updated loads of tests. dotnet/aspnetcore#6364
12 tasks
NTaylorMullen
commented
Jun 4, 2019
| @@ -133,7 +133,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s | |||
| writer.WriteEndObject(); | |||
There was a problem hiding this comment.
All the changes here are a direct copy from Razor. Sadly our serialization logic is in the VS windows specific binary.
NTaylorMullen
commented
Jun 4, 2019
| @@ -0,0 +1,136 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
Git diff failure here. Did not touch all of this.
NTaylorMullen
commented
Jun 4, 2019
| @@ -0,0 +1,334 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
ajaybhargavb
approved these changes
Jun 5, 2019
| services.AddSingleton<RazorCompletionItemProvider, DirectiveCompletionItemProvider>(); | ||
| services.AddSingleton<RazorCompletionItemProvider, DirectiveAttributeCompletionItemProvider>(); | ||
| services.AddSingleton<RazorCompletionItemProvider, DirectiveAttributeParameterCompletionItemProvider>(); | ||
| services.AddSingleton<RazorCompletionItemProvider, DirectiveAttributeTransitionCompletionItemProvider>(); |
There was a problem hiding this comment.
Any reason this logic can't be merged with DirectiveAttributeCompletionItemProvider?
There was a problem hiding this comment.
It might eventually but for now it wouldn't work as expected in VS because we can't intermingle @... with HTML completions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagHelperDescriptorJsonConverterto match what is in Razor.Completionnamespace to hold off of Razor's various completion pieces.@...when in a directive attribute compatible area when no text has been typed.AttributeCompletionDescription. There's more work that needs to be done here to be able to delete Razor.VSCode's description info types in favor of Razor's.Directives,DirectiveAttributes andDirectiveAttributeParameters.RazorDiagnosticPublisherto handle cases when the underlyingRazorCodeDocumenthas been garbage collected. Razor no longer caches these objects.dotnet/aspnetcore#6364