Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Tag Helpers: Add design time projections for attributes #207

Closed
NTaylorMullen opened this issue Oct 22, 2014 · 1 comment
Closed

Tag Helpers: Add design time projections for attributes #207

NTaylorMullen opened this issue Oct 22, 2014 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-beta2

Comments

@NTaylorMullen
Copy link

Right now when a TagHelper specifies an attribute should be more than just an HTML string we don't project the users code into the correct location within the generated C# file.

AKA:

public class SomeTagHelper : TagHelper
{
   public int Foo { get; set; }
}
<some foo="5" /> <!-- The 5 is not mapped to the generated C# file and therefore appears as plain text. -->
@NTaylorMullen NTaylorMullen self-assigned this Oct 23, 2014
@danroth27 danroth27 added this to the 4.0.0-beta2 milestone Oct 27, 2014
NTaylorMullen pushed a commit that referenced this issue Nov 25, 2014
Add line mappings to project TagHelper attribute values.
3bafd0d 
- We now create LineMappings for instances where a TagHelper's attribute value is not of a string type.
- This will enable the Razor editor to create projections from .cshtml => .cs for TagHelper attributes.
- Modified the TagHelperCodeGenerator and TagHelperBlockBuiler to accurately track the attribute values start locations so it could flow into code generation.
- Modified existing tests to account for the new line mappings.

#207
@NTaylorMullen NTaylorMullen mentioned this issue Nov 25, 2014
Merged
NTaylorMullen pushed a commit that referenced this issue Dec 11, 2014
Add line mappings to project TagHelper attribute values.
5d22edb 
- We now create LineMappings for instances where a TagHelper's attribute value is not of a string type.
- This will enable the Razor editor to create projections from .cshtml => .cs for TagHelper attributes.
- Modified the TagHelperCodeGenerator and TagHelperBlockBuiler to accurately track the attribute values start locations so it could flow into code generation.
- Modified existing tests to account for the new line mappings.

#207
NTaylorMullen pushed a commit that referenced this issue Dec 15, 2014
Add line mappings to project TagHelper attribute values.
25f71e0 
- We now create LineMappings for instances where a TagHelper's attribute value is not of a string type.
- This will enable the Razor editor to create projections from .cshtml => .cs for TagHelper attributes.
- Modified the TagHelperCodeGenerator and TagHelperBlockBuiler to accurately track the attribute values start locations so it could flow into code generation.
- Modified existing tests to account for the new line mappings.

#207
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Dec 15, 2014
React to aspnet/Razor#207 changes.
d77238b
NTaylorMullen pushed a commit that referenced this issue Dec 18, 2014
Add line mappings to project TagHelper attribute values.
6b94a47 
- We now create LineMappings for instances where a TagHelper's attribute value is not of a string type.
- This will enable the Razor editor to create projections from .cshtml => .cs for TagHelper attributes.
- Modified the TagHelperCodeGenerator and TagHelperBlockBuiler to accurately track the attribute values start locations so it could flow into code generation.
- Modified existing tests to account for the new line mappings.

#207
NTaylorMullen pushed a commit that referenced this issue Dec 22, 2014
Add line mappings to project TagHelper attribute values.
a86b0dc 
- We now create LineMappings for instances where a TagHelper's attribute value is not of a string type.
- This will enable the Razor editor to create projections from .cshtml => .cs for TagHelper attributes.
- Modified the TagHelperCodeGenerator and TagHelperBlockBuiler to accurately track the attribute values start locations so it could flow into code generation.
- Modified existing tests to account for the new line mappings.

#207
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Dec 22, 2014
React to aspnet/Razor#207 changes.
6afd871
@NTaylorMullen
Copy link
Author

a86b0dc

NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Jan 15, 2015
React to aspnet/Razor#207 changes.
33a7ba4
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Jan 16, 2015
React to aspnet/Razor#207 changes.
4559a09
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Jan 19, 2015
React to aspnet/Razor#207 changes.
029a1be
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Jan 22, 2015
React to aspnet/Razor#207 changes.
6b089d9
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Jan 27, 2015
React to aspnet/Razor#207 changes.
d86151b
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Jan 29, 2015
React to aspnet/Razor#207 changes.
c04dc15
NTaylorMullen pushed a commit to aspnet/Mvc that referenced this issue Feb 1, 2015
React to aspnet/Razor#207 changes.
cf7d428
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta2
Development

No branches or pull requests
2 participants
@danroth27 @NTaylorMullen