This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Redesign TagHelper content modes. #250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <remarks> | ||
| /// Child content is only executed once. Successive calls to this delegate return a cached result. | ||
| /// </remarks> | ||
| public Func<Task<string>> GetChildContentAsync { get; } |
There was a problem hiding this comment.
Maybe call this GetChildContentDelegate - we have some precedence for naming delegates it in this fashion elsewhere in Mvc.
NTaylorMullen
force-pushed
the
thprojections.207
branch
from
3bafd0d to
7f2ec08
Compare
NTaylorMullen
force-pushed
the
thcontentmode.221
branch
from
b23aad6 to
1cd182b
Compare
|
Updated to address comments (still design). |
NTaylorMullen
force-pushed
the
thcontentmode.221
branch
3 times, most recently
from
a06a1d0 to
3eae637
Compare
NTaylorMullen
force-pushed
the
thprojections.207
branch
from
7f2ec08 to
871e82c
Compare
NTaylorMullen
force-pushed
the
thcontentmode.221
branch
from
3eae637 to
0d7b0c8
Compare
NTaylorMullen
changed the title
|
Added tests. |
NTaylorMullen
force-pushed
the
thprojections.207
branch
from
871e82c to
6b94a47
Compare
NTaylorMullen
force-pushed
the
thcontentmode.221
branch
from
6987a59 to
bfb620b
Compare
| /// </summary> | ||
| /// <returns>Content rendered by children.</returns> | ||
| /// <remarks> | ||
| /// Child content is only executed once. Successive calls to this delegate return a cached result. |
There was a problem hiding this comment.
currently will execute the Func on every call. to behave as described, need a Task<string> _childContentAsync field and
if (_childContentAsync == null)
{
_childContentAsync = _getChildContentAsync();
}
return _childContentAsync;nit: better names might be _getChildContentAsyncFunc and _getChildContentAsync since the Func itself isn't async and just returns a Task
There was a problem hiding this comment.
It was a tough call, the caching logic is done indirectly in the TagHelperExecutionContext. The reason why it's done there is because the CodeGen needs access to it and CodeGen doesn't have access to the TagHelperContext since TagHelperContext is 1-1 with each TagHelper and created inside the TagHelperRunner.
It's a rough situation but I'm open to alternatives.
There was a problem hiding this comment.
then <remarks/> make no sense here. remove.
added 4 commits
December 19, 2014 17:34
- Removed all tests and instances of ContentBehavior in preparation for moving to a non-ContentBehavior based design. - Removed ContentBehavior specific CodeGeneration. #221
…nt modes. - Added PreContent, PostContent and ContentSet properties to TagHelperOutput. - Added GeneratePreContent, GeneratePostContent and SupressOutput methods to TagHelperOutput. - Added multile ExecuteChildContentAsync and GetChildContentAsync to the rendering phase, ultimately only exposing GetChildContentAsync to a TagHelper author. - Added more knowledge of StartWritingScope and EndWritingScope to the TagHelper runtime components. This is to enable the runtime components to utilize the RazorPage's infrastructure to render a delegate to a writer and retrieve its value to ultimately expose it to the user. #221
- Added a new internal ctor for TagHelperExecutionContext since it's used in multiple tests to allow for less friction testing. #221
- Modified the CSharpTagHelperCodeRenderer to understand a single line of TagHelper rendering (instead of doing different things based on ContentBehavior). - Modified existing CodeGen output to reflect new content changes. #221
NTaylorMullen
force-pushed
the
thprojections.207
branch
from
6b94a47 to
a86b0dc
Compare
NTaylorMullen
force-pushed
the
thcontentmode.221
branch
from
bfb620b to
80437f6
Compare
|
Updated |
|
Closing and re-opening against dev. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed ContentBehavior
Re-design TagHelperOutput and runtime dependencies to allow all content modes.
Modify tests to allow new content mode design for runtime components.
Added CodeGen for TagHelper content mode redesign.
Tag Helpers: Redesign of Tag Helpers content mode #221
_Note:_ Will add tests once design is good.
/cc @dougbu @pranavkm