Cookies middleware fails on mono as it depends on GZipStream

[Praburaj]

Cookies middleware does not work on mono as the TicketSerializer it uses compresses the cookie response using GZipStream.

System.NotImplementedException: The requested feature is not implemented.
  at System.IO.Compression.GZipStream..ctor (System.IO.Stream stream, CompressionLevel compressionLevel) [0x00000] in <filename unknown>:0 
  at (wrapper remoting-invoke-with-check) System.IO.Compression.GZipStream:.ctor (System.IO.Stream,System.IO.Compression.CompressionLevel)
  at Microsoft.AspNet.Security.DataHandler.Serializer.TicketSerializer.Serialize (Microsoft.AspNet.Security.AuthenticationTicket model) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.DataHandler.SecureDataFormat`1[Microsoft.AspNet.Security.AuthenticationTicket].Protect (Microsoft.AspNet.Security.AuthenticationTicket data) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.Cookies.CookieAuthenticationHandler+<ApplyResponseGrantAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
System.NotImplementedException: The requested feature is not implemented.
  at System.IO.Compression.GZipStream..ctor (System.IO.Stream stream, CompressionLevel compressionLevel) [0x00000] in <filename unknown>:0 
  at (wrapper remoting-invoke-with-check) System.IO.Compression.GZipStream:.ctor (System.IO.Stream,System.IO.Compression.CompressionLevel)
  at Microsoft.AspNet.Security.DataHandler.Serializer.TicketSerializer.Serialize (Microsoft.AspNet.Security.AuthenticationTicket model) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.DataHandler.SecureDataFormat`1[Microsoft.AspNet.Security.AuthenticationTicket].Protect (Microsoft.AspNet.Security.AuthenticationTicket data) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.Cookies.CookieAuthenticationHandler+<ApplyResponseGrantAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 

[akoeplinger]

GZipStream works on Mono, but it only supports the overload that takes a CompressionMode: https://github.com/mono/mono/blob/master/mcs/class/System/System.IO.Compression/GZipStream.cs#L43

[Praburaj]

@akoeplinger Thanks! .@Tratcher - looks like there is a way to unblock this scenario.

[Praburaj]

@akoeplinger - By change do you know if this constructor of GZipStream is going to be available as well on mono?

[akoeplinger]

@Praburaj which constructor do you mean? The one used in PR #30 should work.

[Praburaj]

yes this works. But does this constructor offer the same level of compression like passing in a CompressionLevel?

[akoeplinger]

I don't know how well the compression works, but that is an implementation detail and shouldn't matter here. Or do you actually need absolutely the best compression ratio you can get?

[Tratcher]

The compression can matter. We have to deal with 4kb browser cookie size limits.

[akoeplinger]

@Tratcher oh yeah, that sounds like a valid concern then. PRs to Mono are welcome I guess

[Praburaj]

With a bit more research on GZipStream class - on .net framework using GZipStream(Stream, CompressionMode) (The constructor that works on both mono and .net) - this constructor under the covers uses CompressionLevel.Optimal. So we can remove the work around and use this constructor for both mono and MS .net.