Skip to content
This repository was archived by the owner on Nov 22, 2018. It is now read-only.

Replace UseSession(SessionOptions) with UseSession(Action<SessionOptions>) #174

Closed
HaoK opened this issue Jun 30, 2017 · 5 comments
Closed

Comments

@HaoK
Copy link
Member

HaoK commented Jun 30, 2017

Since the session middleware is using IOptions, we should mirror how we normally configure options... It should instead always use IOptions and apply the action to it afterwards (basically a PostPostConfigureOptions)

We should revisit any other middleware that are using this pattern and using IOptions

UseSession(new SessionOptions()) => UseSession(o => { })

@muratg
Copy link

muratg commented Sep 26, 2017

@HaoK is this still a valid issue? Are we going to do this?

@HaoK
Copy link
Member Author

HaoK commented Sep 26, 2017

Its a consistency issue, but I'm not sure this is something we could change in a minor release (breaking changes and all)

@Tratcher
Copy link
Member

We could add the new one.

@HaoK
Copy link
Member Author

HaoK commented Sep 26, 2017

Yeah we could add that across the board, UseXyz(o => { }) everywhere that's currently only taking UseXyz(new XyzOptions())

@aspnet-hello
Copy link

This issue was moved to dotnet/aspnetcore#2402

@aspnet aspnet locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants