NullReferenceException when logging as Trace and an argument is null #1005

moozzyk · 2017-10-10T19:36:43Z

System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Object.GetType()
   at Microsoft.AspNetCore.SignalR.Client.Internal.SignalRClientLoggerExtensions.<>c.<IssueInvocation>b__33_0(Object a)
   at System.Linq.Enumerable.SelectArrayIterator`2.MoveNext()
   at System.String.Join(String separator, IEnumerable`1 values)
   at Microsoft.AspNetCore.SignalR.Client.Internal.SignalRClientLoggerExtensions.IssueInvocation(ILogger logger, String invocationId, String returnType, String methodName, Object[] args)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCore(String methodName, InvocationRequest irq, Object[] args, Boolean nonBlocking)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.SendAsyncCore(String methodName, Object[] args, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.<SendAsync>d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at ChatClient.ChatClient.<SendMessage>d__6.MoveNext() in C:\source\SignalR-Samples\ChatSample\ChatClient\ChatClient.cs:line 56

here.

The text was updated successfully, but these errors were encountered:

BrennanConroy · 2017-10-10T19:52:20Z

Nice, so we should probably handle null arguments

moozzyk · 2017-10-10T19:54:14Z

Yes. I did not notice but when I pressed Ctrl+C Console.ReadLine() returned null which I tried to send and got the exception. I think we should review logging since I think I saw the same pattern in at least one more place.

Storing exception thrown during parameter binding and rethrowing when the method is about to throw. This allows completing invocations with a HubException and keeping the connection open. We will also no longer close the connection if parameters for client side methods cannot be bound. We will log and continue. Fixes: #818 (Also fixing #1005 because I was just touching this line)

Late parameter binding Storing exception thrown during parameter binding and rethrowing when the method is about to throw. This allows completing invocations with a HubException and keeping the connection open. We will also no longer close the connection if parameters for client side methods cannot be bound. We will log and continue. Fixes: #818 (Also fixing #1005 because I was just touching this line)

moozzyk · 2017-10-30T18:32:31Z

Fixed in 18f770e

moozzyk changed the title ~~NullReferenceException when logging~~ NullReferenceException when logging as Trace and an argument is null Oct 10, 2017

moozzyk closed this as completed Oct 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NullReferenceException when logging as Trace and an argument is null #1005

NullReferenceException when logging as Trace and an argument is null #1005

moozzyk commented Oct 10, 2017 •

edited

Loading

BrennanConroy commented Oct 10, 2017

Uh oh!

moozzyk commented Oct 10, 2017

Uh oh!

moozzyk commented Oct 30, 2017 •

edited

Loading

Uh oh!

NullReferenceException when logging as Trace and an argument is null #1005

NullReferenceException when logging as Trace and an argument is null #1005

Comments

moozzyk commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BrennanConroy commented Oct 10, 2017

Uh oh!

moozzyk commented Oct 10, 2017

Uh oh!

moozzyk commented Oct 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moozzyk commented Oct 10, 2017 •

edited

Loading

moozzyk commented Oct 30, 2017 •

edited

Loading