Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Flaky Docker Redis tests #1160

@analogrelay

Description

@analogrelay

Expanding this somewhat: I now have consistent failures on my desktop at home due to the docker container not starting properly. We should add some better diagnostics to these tests to report issues if the container fails to start properly so we can track down why they are failing on some (read: my) machines.

When your Docker for Windows instance is configured either for "Windows Container" or "Linux Containers on Windows" (LCOW), the Redis tests fail to run. In the first case, because Redis is a linux container and in the second case because of some bug in LCOW (it's experimental) that causes it to fail.

We should detect those cases and skip running the tests. You can detect this by the following command:

With Windows Containers or LCOW on (what we don't want):

› docker system info -f "{{.OSType}}"
windows

With it off (what we want):

› docker system info -f "{{.OSType}}"
linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions