Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Rationalize IConnection and ConnectionContext #1892

Closed
davidfowl opened this issue Apr 7, 2018 · 2 comments
Closed

Rationalize IConnection and ConnectionContext #1892

davidfowl opened this issue Apr 7, 2018 · 2 comments
Assignees
@davidfowl
Labels
3 - Done cost: M Will take 3 - 5 days to complete type: Enhancement
Milestone
2.1.0-rc1

Comments

@davidfowl
Copy link
Member

davidfowl commented Apr 7, 2018 •
edited
Loading

This is the last remaining piece of work to do from #1453.

The cheapest solution I see is to:

  • Implement ConnectionContext on the HttpConnection
  • Introduce IConnectionFactory to the HubConnection layer
public IConnectionFactory
{
    Task<ConnectionContext> ConnectAsync(TransferFormat transferFormat);
}

The last thing to figure out after that would be how we do DisposeAsync (it could be Abort), see aspnet/KestrelHttpServer#2054
@davidfowl davidfowl added status: Needs Design cost: M Will take 3 - 5 days to complete labels Apr 7, 2018
@davidfowl davidfowl mentioned this issue Apr 7, 2018
Merged
@davidfowl davidfowl added this to the 2.1.0-rc1 milestone Apr 7, 2018
@davidfowl davidfowl self-assigned this Apr 7, 2018
@davidfowl
Copy link
Member Author

/cc @KPixel

@KPixel
Copy link

KPixel commented Apr 7, 2018

Great!
This looks like the last piece of the refactoring.

I haven't been able to work on this project this week. But I will have time for it next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
3 - Done cost: M Will take 3 - 5 days to complete type: Enhancement
Projects
None yet
Milestone
2.1.0-rc1
Development

No branches or pull requests
2 participants
@davidfowl @KPixel