Don't log message data

[mikaelm12]

Issue: #1449
We don't want to log message content on the client.

[BrennanConroy]

Pretty sure there are more locations that we need to change.

[davidfowl]

Also tests?

[analogrelay]

Also tests?

We don't do a lot of logging testing. But I guess we could. The test I'd prefer most for this one is a test that runs a full client/server scenario (possibly in separate tests) using TestSink/TestLogger and then searches every log message for a unique string present in the payload to verify it is not there, rather than one that tests specific messages and is therefore brittle as we change messages.

[davidfowl]

It comes down to understanding how important this change is. If another change regresses this I have extremely low confidence that we'll catch it in a code review.

[analogrelay]

Exactly the purpose of the test I suggested ;)

[davidfowl]

@anurse and @mikaelm12 can you talk to @anpete and @ajcvickers about how EF handles logging of parameter values?

[mikaelm12]

Not working on this atm.