This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Exceptions from user's event handlers should be caught and logged #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they can spoil event queue and make the client not raise the Received event anymore Fixes: #818
davidfowl
reviewed
Sep 5, 2017
| @@ -747,6 +747,128 @@ public void CannotStartConnectionWithInvalidTransportType(TransportType requeste | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task CanReceiveDataEvenIfUserThrowsInConnectedEvent() | |||
There was a problem hiding this comment.
Add a test for a synchronous exception.
|
🆙📅 |
BrennanConroy
approved these changes
Sep 5, 2017
|
This PR should be on alpha1. You can change it by "editing" the title |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise they can spoil event queue and make the client not raise the Received event anymore
Fixes: #818