Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Exceptions from user's event handlers should be caught and logged #819

Closed
wants to merge 2 commits into from

Conversation

moozzyk
Copy link
Contributor

@moozzyk moozzyk commented Sep 5, 2017

Otherwise they can spoil event queue and make the client not raise the Received event anymore

Fixes: #818

Otherwise they can spoil event queue and make the client not raise the Received event anymore

Fixes: #818
@@ -747,6 +747,128 @@ public void CannotStartConnectionWithInvalidTransportType(TransportType requeste
}

[Fact]
public async Task CanReceiveDataEvenIfUserThrowsInConnectedEvent()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for a synchronous exception.

@moozzyk
Copy link
Contributor Author

moozzyk commented Sep 5, 2017

🆙📅

@BrennanConroy
Copy link
Member

This PR should be on alpha1. You can change it by "editing" the title

@moozzyk moozzyk changed the base branch from dev to rel/1.0.0-alpha1 September 5, 2017 19:16
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moozzyk
Copy link
Contributor Author

moozzyk commented Sep 6, 2017

ceff4bd

@moozzyk moozzyk closed this Sep 6, 2017
@moozzyk moozzyk deleted the pawelka/bug-818 branch September 15, 2017 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants