Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Move to Node10 #608

Closed
ryanbrandenburg opened this issue Jul 11, 2018 · 1 comment
Closed

Move to Node10 #608

ryanbrandenburg opened this issue Jul 11, 2018 · 1 comment

Comments

@ryanbrandenburg
Copy link
Contributor

Let's move to Node10 for our templating builds.
@ryanbrandenburg
Copy link
Contributor Author

Upgrading to node 10 seems to break angular for mac. The suggested fixes seem to be 1) Don't check in package-lock.json files. 2) Use a version of npm that won't complain.

As per the discussion here we decided that this work isn't worth it until they've resolved the angular/mac issue.

mikeharder added a commit to aspnet/Universe that referenced this issue Oct 3, 2018
@mikeharder
Add Linux, Node8, and Node10 to test matrix (#1445)
9c37082 
- Test both Node8 and Node10 on Windows and Linux
- Only test Node8 on MacOS, since the ASP.NET Core 2.1.X templates are incompatible with Node10 on macOS
  - aspnet/Templating#608
- Move Windows build to "Hosted VS2017" pool which has more agents
  - We would rather use the "Hosted" pool, but "npm restore" currently fails on agents in this pool
- Remove "Preview" from Mac pool name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanbrandenburg