This repository was archived by the owner on Oct 18, 2018. It is now read-only.
wip: Add a package dependency from Microsoft.AspNetCore.App/All to NETCore.App #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
added
the
Servicing-consider
JunTaoLuo
reviewed
Jul 13, 2018
| @@ -15,4 +16,8 @@ | |||
| <Content Include="lib\$(TargetFramework)\_._" PackagePath="%(Identity)" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.NETCore.App" Version="[$(RuntimeFrameworkVersion), 2.2.0)" PrivateAsset="None" /> | |||
There was a problem hiding this comment.
Which version would we need to target? The bundled version (latest patch) or the pinned version (major.minor.0)?
There was a problem hiding this comment.
If we add this at all, it should be latest patch. Otherwise, adding this only creates problems and doesn't solve any.
natemcmaster
changed the title
|
Per discussion, this is not approved for 2.1. |
natemcmaster
removed
the
Servicing-consider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1256
This adds a package dependency from AspNetCore.App to NETCore.App. This change would need to be added along with dotnet/sdk#2394.
cc @nguerrera @dsplaisted @DamianEdwards