Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Update to newer tooling #167

Closed
wants to merge 7 commits into from
Closed

Update to newer tooling #167

wants to merge 7 commits into from

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Oct 8, 2017

A set of infrastructure changes

  • ignore launchSettings.json files
  • move to MSBuild v15 (aka VS2017 tooling)
  • move to StyleCop.MSBuild v5.0.0 (aka something that groks C#6)
  • move test output to shut NuGet.exe pack up

@dnfclas
Copy link

dnfclas commented Oct 8, 2017

@dougbu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dougbu
Copy link
Contributor Author

dougbu commented Oct 8, 2017

@natemcmaster could you please have a look at the build.cmd changes?

@dougbu
Copy link
Contributor Author

dougbu commented Oct 8, 2017

@rynowak could you please scan the rest of the files? Most of those changes follow consistent patterns. Might be even easier to look at the individual comments -- fewer patterns.

@dougbu dougbu requested review from rynowak and natemcmaster October 8, 2017 03:22
rynowak
rynowak approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick scan of this and it all seems fine 👍

@dougbu dougbu mentioned this pull request Oct 9, 2017
Closed
natemcmaster
natemcmaster approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natemcmaster
Copy link
Contributor

This is not meant to build on Linux, right? Let's disable Travis CI for this repo. cc @Eilon

@dougbu
Copy link
Contributor Author

dougbu commented Oct 9, 2017

@natemcmaster yup. This repo doesn't work cross-platform yet. I added a minimal Travis configuration to this PR that disables builds on all branches except not.a.branch.

AppVeyor builds aren't kicking off but I'll check this in soon (once I've got the status badge URL in README.md) to unblock other PRs.

@Eilon
Copy link
Contributor

Eilon commented Oct 9, 2017

Yeah we're leaving Travis enabled for this repo, but disabling all its builds. It's a hassle to enable/disable the CIs on the service side, so I'd rather leave them on.

@Eilon
Copy link
Contributor

Eilon commented Oct 9, 2017

(And this repo will eventually build on Linux too.)

@dougbu dougbu force-pushed the dougbu/infrastructure.updates branch from 29df553 to 73f907e Compare October 9, 2017 18:52
@dougbu
Copy link
Contributor Author

dougbu commented Oct 9, 2017

d03e1d1

@dougbu dougbu closed this Oct 9, 2017
@dougbu dougbu deleted the dougbu/infrastructure.updates branch October 9, 2017 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eilon Eilon Eilon approved these changes

@rynowak rynowak rynowak approved these changes

@natemcmaster natemcmaster natemcmaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dougbu @dnfclas @natemcmaster @Eilon @rynowak