Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Proposal: use microsoft/dotnet image for CoreCLR images #124

Closed
ahmetb opened this issue Dec 11, 2015 · 4 comments
Closed

Proposal: use microsoft/dotnet image for CoreCLR images #124

ahmetb opened this issue Dec 11, 2015 · 4 comments
Milestone

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Dec 11, 2015

We should probably start using use the new microsoft/dotnet images soon?

@glennc wdyt?
@muratg track this for rc2 as well maybe?

@muratg
Copy link

muratg commented Dec 11, 2015

👍

@glennc
Copy link
Member

glennc commented Dec 15, 2015

Yeah, it does mean significant changes for us. I think the only thing we really need to layer on top is libuv, and the mono stuff. Everything else should be done by the dotnet cli base image. So some of our stuff gets simpler, which is nice.

A couple of ideas for more stuff the ASP.NET images could do above the CLI image is:

  1. do some on-build style stuff: Create a non-root user and directory for an app.
  2. pre-restore a bunch of packages so that your restore is faster. If we did this I think we would create another image that inherits from latest and then restores packages, or something like that. So if people want a faster restore time inside the container they can use this image. You would only use it when building your app inside a container.

@ahmetalpbalkan what do you think about these ideas?

@ahmetb
Copy link
Contributor Author

ahmetb commented Dec 15, 2015

@glennc For 2, I still tend to think if we add ONBUILD COPY project.json first and ONBUILD RUN dnvm restore, we will not need pre-restored packages. Only the first time and changes to project.json will be a bit slow is all.

I believe dotnet folks are also thinking of an onbuild image (dotnet/dotnet-docker#14 (comment)) we can coordinate. I think we should move forward with this idea, though, we can evaluate onbuild separately.

@muratg muratg modified the milestones: 1.0.0, 1.0.0-rc2 Apr 5, 2016
@muratg muratg modified the milestones: Backlog, 1.0.0 May 26, 2016
@ahmetb
Copy link
Contributor Author

ahmetb commented Jun 29, 2016

closing in favor of #136

@ahmetb ahmetb closed this as completed Jun 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants