Skip to content

Use build triggers #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahmetb opened this issue Nov 22, 2015 · 4 comments
Closed

Use build triggers #14

ahmetb opened this issue Nov 22, 2015 · 4 comments

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Nov 22, 2015

In aspnet image we use build trigger such as:

image

In case one debian/mono repos get rebuilt (such as security update) we get rebuilt, too. Please consider enabling that for this repo as well (see Build Settings tab) @dleeapho

@MichaelSimons
Copy link
Member

There are two potential issue with using build triggers that we need to look out for.

  1. Previously, the CLI team was manually publishing the Debian packages to the repo after the package was signed off on. This was not part of their automated build process. We need to follow-up with them to see if their process has changed. We could make use of a build trigger if need be.
  2. Docker does not have support for automatically rebuilding dependent images - https://forums.docker.com/t/automatic-re-build-of-depending-images/594. This causes issues with the onbuild image. It must be rebuilt after the base image is built.

@ahmetb
Copy link
Contributor Author

ahmetb commented Nov 23, 2015

@MichaelSimons valid points but having this is better than nothing and I don't think onbuild image will be impacted with that. Simply if there's a newer build of buildpack-deps:trusty-scm all tags will be triggered to build again from source.

Our builds should be idempotent as in it should not matter when or how many times we're building these images. If there's a critical vulnerability in buildpack-deps:trusty-scm, we need to keep track of those otherwise and manually trigger a rebuild (which I don't think anybody would bother). Makes sense?

@MichaelSimons
Copy link
Member

@ahmetalpbalkan, regarding the onbuild image. This image is based on the Microsoft/dotnet:0.0.1-alpha image. Because of this, the onbuild image must be rebuilt anytime the Microsoft/dotnet:0.0.1-alpha image if rebuilt. More specific, it needs to be rebuilt after the Microsoft/dotnet:0.0.1-alpha image is built. Docker build triggers cause the all images to get rebuilt concurrently. This means the onbuild images produced by these build triggers are incorrect because they are based on the previously built Microsoft/dotnet:0.0.1-alpha image. Again this appears to be a limitation Docker has on their backlog - https://forums.docker.com/t/automatic-re-build-of-depending-images/594

@MichaelSimons
Copy link
Member

I added the appropriate repository links as part of #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants