-
Notifications
You must be signed in to change notification settings - Fork 2k
Use build triggers #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There are two potential issue with using build triggers that we need to look out for.
|
@MichaelSimons valid points but having this is better than nothing and I don't think onbuild image will be impacted with that. Simply if there's a newer build of Our builds should be idempotent as in it should not matter when or how many times we're building these images. If there's a critical vulnerability in |
@ahmetalpbalkan, regarding the onbuild image. This image is based on the Microsoft/dotnet:0.0.1-alpha image. Because of this, the onbuild image must be rebuilt anytime the Microsoft/dotnet:0.0.1-alpha image if rebuilt. More specific, it needs to be rebuilt after the Microsoft/dotnet:0.0.1-alpha image is built. Docker build triggers cause the all images to get rebuilt concurrently. This means the onbuild images produced by these build triggers are incorrect because they are based on the previously built Microsoft/dotnet:0.0.1-alpha image. Again this appears to be a limitation Docker has on their backlog - https://forums.docker.com/t/automatic-re-build-of-depending-images/594 |
I added the appropriate repository links as part of #36. |
In aspnet image we use build trigger such as:
In case one debian/mono repos get rebuilt (such as security update) we get rebuilt, too. Please consider enabling that for this repo as well (see Build Settings tab) @dleeapho
The text was updated successfully, but these errors were encountered: