Skip to content

Added preview1/rc2 images for .NET Core and CLI Tools. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2016
Merged

Added preview1/rc2 images for .NET Core and CLI Tools. #36

merged 1 commit into from
May 12, 2016

Conversation

MichaelSimons
Copy link
Member

These images are available under a test Docker Hub repository if you want to pull them.

@naamunds, @dleeapho @glennc

@MichaelSimons MichaelSimons added this to the RC2 milestone May 10, 2016
@MichaelSimons MichaelSimons self-assigned this May 10, 2016
@glennc
Copy link

glennc commented May 11, 2016

This still requires @blackdwarf to add text and such to the .md right?

@MichaelSimons
Copy link
Member Author

@glennc correct the readme content is just a placeholder until @blackdwarf provides the official content. My apologies for not calling this out.

@@ -0,0 +1,9 @@
FROM microsoft/dotnet:1.0.0-preview1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be thinking of onbuild based off of :core instead? With ENTRYPOINT ["dotnet"] users would build in their publish output folder and run their (portable) app with docker run microsoft/dotnet:onbuild myapp.dll it's more lightweight and I'm not sure whether the typical onbuild scenario needs the full sdk.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dleeapho I am not sure I am following? onbuild as defined has to have the full sdk in order to restore and build. Where/when do you see this happening?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I positing that there is another scenario for onbuild, instead of restoring and building in-container that onbuild could also be used to quickly run any portable app. The onbuild would copy the dotnet publish directory contents and myapp.dll would be the args to the dotnet (muxer) entrypoint. In any case we can wait and see if there is a need for what I'm proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants