Added Dockerfile to download the nightly build of ASP.NET 5 #20
Conversation
|
|
||
| RUN apt-get -qq update && apt-get -qqy install unzip | ||
|
|
||
| RUN curl -sSL https://raw.githubusercontent.com/aspnet/Home/master/kvminstall.sh | sh |
There was a problem hiding this comment.
Should this use the kvminstall.sh from the dev branch as well?
There was a problem hiding this comment.
Yeah I think it should... The master branch has the kvminstall from the latest NuGet.org ("official") release. Granted, they're probably not very different, but might as well use the best version.
|
@ahmetalpbalkan for review. And CLA is confirmed. |
|
Good idea. I have also change the |
|
@ahmetalpbalkan if you can review and sign off then we can merge, thanks! |
|
@Eilon I'm OOF until 1/12 sorry for the delay. @vlesierse Thanks for the PR! Can you please verify if aspnet/Home@ Edit: I realized kvm.sh uses it. Looks good to me, please merge. |
Once merged I'll add the tag to Docker Hub image.
|
Is there a need to squash the commits first? |
|
@vlesierse yes, that'd be great. Squash them into one and git push -f, please. Thanks! |
|
Done |
|
squash LGTM. |
|
Cool! @davidfowl if your Barbadian Interwebz are working, can you merge? |
Added Dockerfile to download the nightly build of ASP.NET 5
When a developer would like to run against the latest build of ASP.NET 5 he can use the
microsoft/aspnet:nightlyimage. This image will point to thehttps://www.myget.org/F/aspnetvnext/api/v2feed to get the runtime and us an ONBUILD to get the latest version of KRE.@giggio has brought this improvement in issue: Create container for aspnet latest dev version