Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Renamed the nightly image to DNX #40

Merged
merged 2 commits into from
Mar 13, 2015
Merged

Renamed the nightly image to DNX #40

merged 2 commits into from
Mar 13, 2015

Conversation

vlesierse
Copy link
Contributor

The ASP.NET 5 team has renamed KRE, KVM to DNX, DNVM. This pull request will make the nightly image to adapt to these changes.

Currently the k and kpm command are still usable, but this shouldn't affect the nightly image in the future.

Example Dockerfile

FROM aspnet:nightly

COPY . /app
WORKDIR /app
RUN kpm restore
ENV DNX_TRACE 1
ENTRYPOINT sleep 10000 | k kestrel

@ghost ghost added the cla-not-required label Mar 12, 2015
@ahmetb
Copy link
Contributor

ahmetb commented Mar 12, 2015

Looks good to me, have you tried manually running any applications on this image? We took it out of CI therefore we have no way to know if it's working or not. Thanks @vlesierse

@vlesierse
Copy link
Contributor Author

Yeah, I have run my own project and the HelloWeb sample from the Home repository successfully using these changes.

ahmetb added a commit that referenced this pull request Mar 13, 2015
Renamed the nightly image to DNX
@ahmetb ahmetb merged commit cadbbb5 into aspnet:master Mar 13, 2015
@ahmetb
Copy link
Contributor

ahmetb commented Mar 13, 2015

thanks @vlesierse. For some reason master is broken after merge... Although that probably has nothing to do with nightly.

@vlesierse
Copy link
Contributor Author

Interesting since it is the beta 1 image. I notice that the kpm restore command resolves NuGet packages with the version beta 3.

@ahmetb
Copy link
Contributor

ahmetb commented Mar 13, 2015

😕 what to do now?

@vlesierse
Copy link
Contributor Author

Working on a fix. I'm planning to checkout the according tag in the repo like the nightly image did before.

@vlesierse vlesierse deleted the dnx-rename branch March 29, 2015 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants