Skip to content
This repository was archived by the owner on Dec 29, 2021. It is now read-only.

Rustfmt #48

Closed
killercup opened this issue Oct 9, 2017 · 3 comments
Closed

Rustfmt #48

killercup opened this issue Oct 9, 2017 · 3 comments

Comments

@killercup
Copy link
Collaborator

Rustfmt the whole codebase and add a CI step to check the formatting.

@epage linked to this config, but I'm more inclined to do it like we do our clippy build, and use rustfmt-nightly just like diesel.

@epage
Copy link
Collaborator

epage commented Oct 9, 2017

Yeah, old rustfmt was to avoid another nightly dependency.

Note that the diesel logic will probably run into problems with travis caches when they upgrade rustfmt. The old version will still exist, so nothing will necessitate an upgrade. Combinging it with my logic would help because it checks if rustfmt is installed and is the expected version. If this fails, it force installs.

@killercup
Copy link
Collaborator Author

Tbh I'd just cargo +nightly-2017-10-09 install rustfmt-nightly --vers "0.2.8" and be done with it. IIRC, we don't cache these things anyway.

killercup added a commit that referenced this issue Oct 9, 2017
@epage
Copy link
Collaborator

epage commented Oct 12, 2017

Fixed by #49

@epage epage closed this as completed Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants