This repository was archived by the owner on Dec 29, 2021. It is now read-only.
fix(cargo): Avoid cargo run
#111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches us from using `cargo run` to `cargo build`, reading where the binary is placed, and callin that instead. Fixes assert-rs#95 because the user changing the `CWD` doesn't impact `cargo build`. Fixes assert-rs#79 because there is no `cargo` output when capturing the user's stdout/stderr. Fixes assert-rs#51 because the user changing the environment doesn't impact `cargo build`. This is a step towards working around assert-rs#100 because we can allow a user to cache the result of `cargo build`.
epage
commented
May 25, 2018
| filenames: Vec<&'a str>, | ||
| } | ||
|
|
||
| fn filenames(msg: cargo::Message, kind: &str) -> Option<String> { |
| ].into_iter() | ||
| .map(OsString::from) | ||
| .collect(), | ||
| pub fn main_binary() -> Result<Self, failure::Error> { |
There was a problem hiding this comment.
Define a proper error for this and related functions
| const CURRENT_TARGET: &str = include_str!(concat!(env!("OUT_DIR"), "/current_target.txt")); | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct Cargo { |
There was a problem hiding this comment.
This new file is generating a lot of warnings from unused code.
I developed more than I'd need. I plan to eventually split this out into is own crate. It'll be reused by stager and other tools I'm working on that need to run cargo programmatically but don't want to link against cargo (slow to build, . This was a testing ground for the idea.
epage
added a commit
to crate-ci/escargot
that referenced
this pull request
May 26, 2018
|
This is superseded by https://github.com/assert-rs/assert_cmd |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches us from using
cargo runtocargo build, reading wherethe binary is placed, and callin that instead.
Fixes #95 because the user changing the
CWDdoesn't impactcargo build.Fixes #79 because there is no
cargooutput when capturing the user'sstdout/stderr.
Fixes #51 because the user changing the environment doesn't impact
cargo build.This is a step towards working around #100 because we can allow a user
to cache the result of
cargo build.