-
Notifications
You must be signed in to change notification settings - Fork 29
Refactor API / source layout? #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
The source layout was an artifact of some early work to include "adapter" types, not unlike what is talked about in #21. The idea was that there would be two namespaces in the root, The layout you describe seems much more usable, I give it a 👍 . |
epage
added a commit
to epage/predicates-rs
that referenced
this issue
Apr 11, 2018
Previously, the API was focused on convinience for importing in a specific way. This change splits out functionality from convinience. The convinience is now done via a prelude module. Fixes assert-rs#17
epage
added a commit
to epage/predicates-rs
that referenced
this issue
Apr 11, 2018
Previously, the API was focused on convenience for importing in a specific way. This change splits out functionality from convenience. The convenience is now done via a prelude module. Fixes assert-rs#17
Merged
epage
added a commit
to epage/predicates-rs
that referenced
this issue
Apr 11, 2018
Previously, the API was focused on convenience for importing in a specific way. This change splits out functionality from convenience. The convenience is now done via a prelude module. Fixes assert-rs#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The layout in the docs / source feels strange with everything buried under the
predicate
module. The goal seems to be to allow imports like:Proposal:
pub use
inlib.rs
Predicate
andBoxedPredicate
in dedicated private files in the root with apub use
inlib.rs
.prelude
module that containsPredicate
predicate
module which only re-exports the factory functions*Predicate
s about using the factories frompredicate
.The standard import would now look like:
Benefits
predicate
module will be narrowed to just factories which imo makes the intent / starting point more clear.The text was updated successfully, but these errors were encountered: