Feature/missing zod chains on refs#177
Open
WickyNilliams wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WickyNilliams
changed the title
Owner
|
I'm sorry I have no idea and tbh no motivation to work on this project atm 😭 |
Collaborator
Author
|
damn. no worries, i totally get it [stares at my own open source projects whose existence i now resent] |
|
@WickyNilliams I took a stab at adding support for "chained validations" on the sub-types of unions in this PR: #312 I'm not sure if it's the exact same thing you were trying to fix, but perhaps similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've tried my hand at getting this just right, but everything always ends up slightly wrong. I can't quite work out where I need to tweak the code to get chains on the named refs, without breaking some other part of the output.
in the process of this, i have uncovered some existing snapshots which i think are incorrect and are related to this (see most recent commit)
just making a PR now as a point of disucssion. any advice on where might be best to handle this would be appreciated