Remove max validation when format is binary#339
Open
darkbasic wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
I've added a regression test to prevent future occurrences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a
maxLengthprop openapi-zod-client automatically adds themaxoperator to ensure the number of characters is appropriate. Unfortunately this won't generate valid zod code whenever theformatis of typebinarybecausemaxis not a valid method forFile(Property 'max' does not exist on type 'ZodType<File, ZodTypeDef, File>').This patch conditionally removes
maxfor binary formats.I thought about changing it with something like the following:
but I'm not sure whether the openapi specs means bytes, KB, characters or what else whenever you specify
maxLengthin abinaryformat.