Skip to content

Join unparented inline spans directly - #369

Open
charliermarsh wants to merge 1 commit into
charlie/ohm-27-flatten-metadata-reachabilityfrom
charlie/ohm-27-join-inline-spans
Open

charliermarsh wants to merge 1 commit into
charlie/ohm-27-flatten-metadata-reachabilityfrom
charlie/ohm-27-join-inline-spans

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Span::to now joins two unparented inline spans directly when they share a syntax context and the result fits inline. Parented spans still take the path that records their dependencies.

The seven-file uv edit used 0.355% fewer rustc instructions across the workspace in eight pairs against −27. The returned span and parent-tracking callbacks matched on 3,264 joins. uv edit

@charliermarsh
charliermarsh force-pushed the charlie/ohm-27-join-inline-spans branch from 96e448e to 60dd8f7 Compare November 8, 2026 14:19
@charliermarsh
charliermarsh changed the base branch from charlie/ohm-26-defer-obligation-spans to charlie/ohm-27-flatten-metadata-reachability November 8, 2026 14:21
@charliermarsh
charliermarsh marked this pull request as ready for review November 8, 2026 14:21
@charliermarsh
charliermarsh added this pull request to stack #377 November 8, 2026 14:21
@charliermarsh
charliermarsh removed this pull request from stack #377 November 8, 2026 17:51
@charliermarsh
charliermarsh added this pull request to stack #381 November 8, 2026 17:51
@charliermarsh
charliermarsh force-pushed the charlie/ohm-27-join-inline-spans branch from 60dd8f7 to dc9799d Compare November 17, 2026 07:31
@charliermarsh
charliermarsh removed this pull request from stack #381 November 17, 2026 07:33
@charliermarsh
charliermarsh added this pull request to stack #426 November 17, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant