Repository navigation
Join unparented inline spans directly - #369
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/ohm-27-join-inline-spans
branch
from
November 8, 2026 14:19
96e448e to
60dd8f7
Compare
charliermarsh
changed the base branch from
charlie/ohm-26-defer-obligation-spans
to
charlie/ohm-27-flatten-metadata-reachability
November 8, 2026 14:21
charliermarsh
marked this pull request as ready for review
November 8, 2026 14:21
charliermarsh
force-pushed
the
charlie/ohm-27-join-inline-spans
branch
from
November 17, 2026 07:31
60dd8f7 to
dc9799d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Span::tonow joins two unparented inline spans directly when they share a syntax context and the result fits inline. Parented spans still take the path that records their dependencies.The seven-file uv edit used 0.355% fewer rustc instructions across the workspace in eight pairs against −27. The returned span and parent-tracking callbacks matched on 3,264 joins. uv edit