Repository navigation
Reuse method attribute anchors for generated awaits - #373
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/ohm-28-anchor-generated-await-spans
branch
from
November 8, 2026 14:19
9493fb1 to
889dc4d
Compare
charliermarsh
marked this pull request as ready for review
November 8, 2026 14:21
charliermarsh
force-pushed
the
charlie/ohm-28-anchor-generated-await-spans
branch
from
November 17, 2026 07:31
889dc4d to
69ead4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an attribute macro generates an
.awaitat the method attribute’s own location, HIR lowering can reuse the preceding method as its span parent. Moving the methods together preserves the generated HIR. The linked test observes the new line and column, and a type error points to the moved attribute.On top of #372, the seven-file uv edit used 0.871% fewer rustc instructions in
uv-resolverand 0.234% fewer across the workspace in eight pairs. uv edit