Skip to content

Defer formatting return-type suggestions for refining_impl_trait - #383

Open
charliermarsh wants to merge 1 commit into
charlie/compile-plain-tests-without-wrappersfrom
charlie/defer-refining-impl-trait-suggestions
Open

charliermarsh wants to merge 1 commit into
charlie/compile-plain-tests-without-wrappersfrom
charlie/defer-refining-impl-trait-suggestions

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Deferring the suggested return type saved 17.51% of the uv-dispatch check and 0.72% across all 14 compiler processes after a seven-file uv edit, measured against −28. Rustc previously formatted the return type before checking whether the refining-impl-trait lint was allowed. The diagnostic now formats it when it constructs the suggestion. uv edit

@charliermarsh
charliermarsh force-pushed the charlie/defer-refining-impl-trait-suggestions branch from 8b4ded8 to b770873 Compare November 9, 2026 17:31
@charliermarsh
charliermarsh changed the base branch from charlie/pin-cargo-release-28 to charlie/compile-plain-tests-without-wrappers November 9, 2026 17:31
@charliermarsh
charliermarsh marked this pull request as ready for review November 9, 2026 17:37
@charliermarsh
charliermarsh added this pull request to stack #395 November 9, 2026 17:38
@charliermarsh
charliermarsh removed this pull request from stack #395 November 12, 2026 17:29
@charliermarsh
charliermarsh added this pull request to stack #413 November 12, 2026 17:29
@charliermarsh
charliermarsh force-pushed the charlie/defer-refining-impl-trait-suggestions branch from b770873 to 625e745 Compare November 17, 2026 07:31
@charliermarsh
charliermarsh removed this pull request from stack #413 November 17, 2026 07:33
@charliermarsh
charliermarsh added this pull request to stack #426 November 17, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant