Skip to content

Keep opaque definition order stable in incremental rlib builds - #411

Open
charliermarsh wants to merge 1 commit into
charlie/order-incremental-opaque-definitionsfrom
charlie/order-native-opaque-definitions
Open

charliermarsh wants to merge 1 commit into
charlie/order-incremental-opaque-definitionsfrom
charlie/order-native-opaque-definitions

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

On the same large CLI, six incremental native rlib builds used 10.62% fewer instructions than the preceding metadata-only fix.

A native rlib embeds the same item metadata that rustc emits for a check. We now stabilize opaque definition order during native rlib builds too. A downstream executable can observe the changed function body while rustc reuses the unchanged metadata prefix.

@charliermarsh
charliermarsh force-pushed the charlie/order-native-opaque-definitions branch from a98e75c to 9482b29 Compare November 12, 2026 15:10
@charliermarsh
charliermarsh marked this pull request as ready for review November 12, 2026 15:15
@charliermarsh
charliermarsh added this pull request to stack #395 November 12, 2026 15:16
@charliermarsh
charliermarsh removed this pull request from stack #395 November 12, 2026 17:29
@charliermarsh
charliermarsh added this pull request to stack #413 November 12, 2026 17:29
@charliermarsh
charliermarsh force-pushed the charlie/order-native-opaque-definitions branch from 9482b29 to 434d9fe Compare November 17, 2026 07:32
@charliermarsh
charliermarsh removed this pull request from stack #413 November 17, 2026 07:33
@charliermarsh
charliermarsh added this pull request to stack #427 November 17, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant