Repository navigation
Keep opaque definition order stable in incremental rlib builds - #411
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/order-native-opaque-definitions
branch
from
November 12, 2026 15:10
a98e75c to
9482b29
Compare
charliermarsh
marked this pull request as ready for review
November 12, 2026 15:15
charliermarsh
force-pushed
the
charlie/order-native-opaque-definitions
branch
from
November 17, 2026 07:32
9482b29 to
434d9fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the same large CLI, six incremental native rlib builds used 10.62% fewer instructions than the preceding metadata-only fix.
A native rlib embeds the same item metadata that rustc emits for a check. We now stabilize opaque definition order during native rlib builds too. A downstream executable can observe the changed function body while rustc reuses the unchanged metadata prefix.