Repository navigation
Keep import definition IDs stable when a sibling import moves - #434
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
This was referenced Nov 19, 2026
charliermarsh
force-pushed
the
charlie/ohm-100-stable-imports
branch
from
November 20, 2026 00:41
2f008a6 to
3f82799
Compare
charliermarsh
changed the base branch from
charlie/pin-cargo-1.100.0-2
to
charlie/recover-closure-impl-lookups
November 20, 2026 00:44
charliermarsh
marked this pull request as ready for review
November 20, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting
use std::slice;fromuv-lockrenumbers a lateruse itertools::Itertools;. Every body that considered that trait during method resolution then has a different fingerprint. We now number imports with the same final path segment together, including inside grouped imports. Removingslicepreserves the identity ofItertools. Switching to a different trait with the same name still invalidates the caller when its resolution changes.In six pairs against the −2 compiler source, the first check after the edit used 28.70% fewer instructions in
uv-lockand 8.89–8.91% fewer across all 18 rustc processes. The number of bodies borrow-checked inuv-lockfell from 101 to 18. uv edit