Require Python 3.8 #528
Draft
Require Python 3.8 #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A possibly less invasive approach might be to stop testing on 3.7 in CI, but otherwise leave the official minimum supported version alone. I wouldn't do that for a maintained project, but for a deprecated one it's kind of the path of least resistance / minimal disruption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original goal here was to fix the CI failure in astral-sh/ruff#19763 (logs) by updating to a version of
ujsonwhere thesetuptools-scmproblem in the log was fixed (5.7.0 -> 5.10.0), but 5.10 isn't available on Python 3.7.This PR also bumps our minimum Python version to 3.8 and then updates the dependencies with
just lock.See also #527
Test Plan
This PR and then all Ruff PRs afterward