RUF013 undocumented limitation `x: CustomClass = None` is not caught

[jond01]

It seems like the following should be caught or at least be added to the documented limitations:

from enum import Enum
from typing import Optional


class Letter(Enum):
    """ok."""

    A = "A"


class CatchMe:
    """class."""


def f(
    letter: Letter = None,  # <--- should be caught
    word: Optional[str] = None,
    catch: CatchMe = None,  # <--- should be caught
) -> None:
    """Doc."""

• List of keywords you searched for before creating this issue: RUF013
• A minimal code snippet that reproduces the bug: https://play.ruff.rs/afaf262e-0615-4732-83aa-4cc32af930c2
• The command you invoked: ruff check file.py --select RUF013
• The current Ruff settings: in the snippet.
• The current Ruff version: 0.7.1

[MichaReiser]

Thanks. I agree that this is surprising. I assume this is "intentional" because Ruff doesn't know to what types Letter resolves. E.g. Letter could be defined as type Letter = str | None in which case the assignment is valid. Not sure if there's another reason for it as well (CC: @charliermarsh )

Documenting this restriction is a good idea.

[dhruvmanila]

I assume this is "intentional" because Ruff doesn't know to what types Letter resolves. E.g. Letter could be defined as type Letter = str | None in which case the assignment is valid. Not sure if there's another reason for it as well

Yeah, I think this is pretty much the reason. The logic considers all custom type to be similar to Any which is the case here.

For context, the fallback branch tries to resolve the name Letter to a qualified name which doesn't exists and thus fallback to using Unknown (similar to Any).

ruff/crates/ruff_linter/src/rules/ruff/typing.rs

Lines 116 to 119 in 4ece8e5

	_ => semantic.resolve_qualified_name(expr).map_or(
	// If we can't resolve the call path, it must be defined in the
	// same file, so we assume it's `Any` as it could be a type alias.
	Some(TypingTarget::Unknown),