Repository navigation
Locate ruff executable in 'bin' directory as installed by 'pip install --target'. - #11450
Merged
charliermarsh merged 2 commits intoMay 16, 2024
Merged
Conversation
Contributor
Author
|
Windows test failures are reported in #11439. |
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PYI001 | 1 | 1 | 0 | 0 | 0 |
| PYI042 | 1 | 1 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
charliermarsh
approved these changes
May 16, 2024
charliermarsh
left a comment
charliermarsh
left a comment
Member
There was a problem hiding this comment.
👍 Thanks. I moved it back to last and decided to use the sysconfig.get_path("scripts") path for the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11246
Summary
This change adds an intermediate additional search path for
find_ruff_bin.I would have added this path as the last one, except that the last one is the one reported to the user, so I made this one second to last.
Test Plan
It's shown to work with this command:
I tried running the same command on Windows, which should work in theory, but building ruff from source on Windows is complicated. Even after installing Rust, ruff fails to build when
libmimalloc-sysfails to build becausegccisn't installed (and the error message points to a broken anchor). I was really hoping Rust would get us away from the Windows as second-class-citizen model :(.