Fix red-knot compilation
#11727
Merged
Fix red-knot compilation
#11727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jun 4, 2024
| use crate::db::tests::TestDb; | ||
| use crate::db::{HasJar, SemanticJar}; | ||
| use crate::module::{ | ||
| set_module_search_paths, ModuleName, ModuleSearchPath, ModuleSearchPathKind, | ||
| resolve_module, set_module_search_paths, ModuleName, ModuleSearchPath, ModuleSearchPathKind, |
There was a problem hiding this comment.
Some of these symbols were missing.
charliermarsh
commented
Jun 4, 2024
| @@ -388,15 +389,6 @@ mod tests { | |||
| assert_public_type(&case, "a", "x", "(Literal[1] | Literal[2])") | |||
| } | |||
|
|
|||
| #[test] | |||
| fn resolve_visible_def() -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
This is defined twice. I assume the second version is a superset of it.
|
|
Sorry! I thought CI was green on the PRs I merged, but there must have been one that didn't merge well into main. Thanks for fixing. |
|
No prob don't sweat it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Perhaps a result of a bad rebase, but
cargo clippy --fix --workspace --all-targets -- -D warningsdoes not pass on main as-is.