ruff server: Formatting a document with syntax problems no longer spams a visible error popup

crates/ruff_server/src/format.rs

@@ -1,6 +1,6 @@
 use ruff_formatter::PrintedRange;
 use ruff_python_ast::PySourceType;
-use ruff_python_formatter::format_module_source;
+use ruff_python_formatter::{format_module_source, FormatModuleError};
 use ruff_text_size::TextRange;
 use ruff_workspace::FormatterSettings;
 
@@ -12,8 +12,16 @@ pub(crate) fn format(
     formatter_settings: &FormatterSettings,
 ) -> crate::Result<String> {
     let format_options = formatter_settings.to_format_options(source_type, document.contents());
-    let formatted = format_module_source(document.contents(), format_options)?;
-    Ok(formatted.into_code())
+    match format_module_source(document.contents(), format_options) {
+        Ok(formatted) => Ok(formatted.into_code()),
+        // Special case - syntax/parse errors are be handled here instead of
+        // being propagated as visible server errors.
+        Err(FormatModuleError::ParseError(error)) => {
+            tracing::warn!("Unable to format document: {error}");
+            Ok(document.contents().to_string())
+        }
+        Err(err) => Err(err.into()),
+    }
 }
 
 pub(crate) fn format_range(
@@ -24,9 +32,14 @@ pub(crate) fn format_range(
 ) -> crate::Result<PrintedRange> {
     let format_options = formatter_settings.to_format_options(source_type, document.contents());
 
-    Ok(ruff_python_formatter::format_range(
-        document.contents(),
-        range,
-        format_options,
-    )?)
+    match ruff_python_formatter::format_range(document.contents(), range, format_options) {
+        Ok(formatted) => Ok(formatted),
+        // Special case - syntax/parse errors should be handled here instead of
+        // being propagated to become visible server errors.
+        Err(FormatModuleError::ParseError(error)) => {
+            tracing::warn!("Unable to format document range: {error}");
+            Ok(PrintedRange::new(document.contents().to_string(), range))
+        }
+        Err(err) => Err(err.into()),
+    }
 }