Skip to content

[ruff] Preserve parentheses around deque in fix for unnecessary-empty-iterable-within-deque-call (RUF037) #18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/ruff/RUF037.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,6 @@ def f():

def f():
queue = deque() # Ok

def f():
x = 0 or(deque)([])
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use ruff_macros::{ViolationMetadata, derive_message_formats};
use ruff_python_ast::parenthesize::parenthesized_range;
use ruff_python_ast::{self as ast, Expr};
use ruff_text_size::Ranged;

Expand Down Expand Up @@ -107,7 +108,15 @@ fn fix_unnecessary_literal_in_deque(
deque: &ast::ExprCall,
maxlen: Option<&Expr>,
) -> Fix {
let deque_name = checker.locator().slice(deque.func.range());
let deque_name = checker.locator().slice(
parenthesized_range(
deque.func.as_ref().into(),
deque.into(),
checker.comment_ranges(),
checker.source(),
)
.unwrap_or(deque.func.range()),
);
let deque_str = match maxlen {
Some(maxlen) => {
let len_str = checker.locator().slice(maxlen);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: crates/ruff_linter/src/rules/ruff/mod.rs
snapshot_kind: text
---
RUF037.py:6:13: RUF037 [*] Unnecessary empty iterable within a deque call
|
Expand Down Expand Up @@ -127,3 +126,18 @@ RUF037.py:30:13: RUF037 [*] Unnecessary empty iterable within a deque call
31 31 |
32 32 |
33 33 | def f():

RUF037.py:61:13: RUF037 [*] Unnecessary empty iterable within a deque call
|
60 | def f():
61 | x = 0 or(deque)([])
| ^^^^^^^^^^^ RUF037
|
= help: Replace with `deque()`

ℹ Safe fix
58 58 | queue = deque() # Ok
59 59 |
60 60 | def f():
61 |- x = 0 or(deque)([])
61 |+ x = 0 or(deque)()
Loading