[flake8-errmsg] Extend EM101 to support byte strings

[njhearp]

Summary

Fixes #18765

Test Plan

Added test

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[njhearp]

Following the recommendation from the error got the CI tests to pass. I'm just a little concerned about the initial failure.

[MichaReiser]

Following the recommendation from the error got the CI tests to pass. I'm just a little concerned about the initial failure.

What was the initial failure?

[MichaReiser]

I think we should gate this change behind preview as it is an extension of a stable rule

See

ruff/crates/ruff_linter/src/preview.rs

Line 60 in daa385c

pub(crate) const fn is_unicode_to_unicode_confusables_enabled(settings: &LinterSettings) -> bool {

for other cases where we gated behavior behind a preview flag.

[njhearp]

error[E0599]: no method named `enabled` found for reference `&Checker<'_>` in the current scope
   --> crates/ruff_linter/src/rules/flake8_errmsg/rules/string_in_exception.rs:208:32
    |
208 |                     if checker.enabled(Rule::RawStringInException) {
    |                                ^^^^^^^ method not found in `&Checker<'_>`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following traits define an item `enabled`, perhaps you need to implement one of them:
            candidate #1: `Log`
            candidate #2: `tracing_core::subscriber::Subscriber`
            candidate #3: `tracing_subscriber::layer::Filter`
            candidate #4: `tracing_subscriber::layer::Layer`
help: one of the expressions' fields has a method of the same name
    |
208 |                     if checker.settings.rules.enabled(Rule::RawStringInException) {
    |                                +++++++++++++++

The CI error suggested this. I believe it is because of Rust's ownership; it only flagged line 208. I just wanted to make sure there was no problem with it.

[ntBre]

You may just need to rebase or merge main. We recently renamed Checker::enabled to Checker::is_rule_enabled and also made the settings field a method.

[github-actions]

mypy_primer results

No ecosystem changes detected ✅

[njhearp]

I updated it so the change is gated behind the preview flag. Also, I merged with main. Sorry about the mess with the history; I realized it would have been cleaner to rebase.

[MichaReiser]

@njhearp I think something went wrong with your merge. The diff contains too many unrelated changes (which should already be on main?). I'm not quite sure what went wrong here. Could you try doing an interactive rebase and only pick your commits?

[ntBre]

Looks great, thank you!