[Viicos]

The diagnostic message now reports the method name, and range was adapted to be more precise and only
cover the call and argument.

Fixes #27085.

Summary

I got confused by one report of this rule. This is how it looks before this PR:

B005 Using `.strip()` with multi-character strings is misleading
    |
215 | key = ""
216 |
217 | key = key.strip("--").lstrip('--')
    |       ^^^^^^^^^^^^^^^
    |

B005 Using `.strip()` with multi-character strings is misleading
    |
215 | key = ""
216 |
217 | key = key.strip("--").lstrip('--')
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |

Test Plan

[astral-sh-bot]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+15 -15 violations, +0 -0 fixes in 3 projects; 55 projects unchanged)

apache/airflow (+4 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- providers/celery/src/airflow/providers/celery/executors/default_celery.py:263:13: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ providers/celery/src/airflow/providers/celery/executors/default_celery.py:263:52: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
- providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/custom_object_launcher.py:162:56: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/custom_object_launcher.py:162:87: strip-with-multi-characters Using `.rstrip()` with multi-character strings is misleading
- providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/custom_object_launcher.py:171:27: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/custom_object_launcher.py:171:60: strip-with-multi-characters Using `.rstrip()` with multi-character strings is misleading
- scripts/ci/prek/lint_dockerfile.py:57:15: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ scripts/ci/prek/lint_dockerfile.py:57:20: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading

binary-husky/gpt_academic (+9 -9 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- crazy_functions/Audio_Assistant.py:24:32: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ crazy_functions/Audio_Assistant.py:24:34: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
- crazy_functions/Latex_Function.py:465:18: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ crazy_functions/Latex_Function.py:465:27: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading
- request_llms/bridge_moss.py:236:32: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ request_llms/bridge_moss.py:236:41: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
- request_llms/bridge_moss.py:242:29: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ request_llms/bridge_moss.py:242:38: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
- request_llms/bridge_qianfan.py:111:19: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ request_llms/bridge_qianfan.py:111:33: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading
- themes/gradios.py:16:25: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ themes/gradios.py:16:31: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading
- themes/gradios.py:18:25: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ themes/gradios.py:18:31: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading
- themes/gradios.py:33:29: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ themes/gradios.py:33:35: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading
- themes/gradios.py:35:29: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ themes/gradios.py:35:35: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading

bokeh/bokeh (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- src/bokeh/plotting/_graph.py:141:20: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ src/bokeh/plotting/_graph.py:141:22: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading
- src/bokeh/plotting/_graph.py:141:78: strip-with-multi-characters Using `.strip()` with multi-character strings is misleading
+ src/bokeh/plotting/_graph.py:141:80: strip-with-multi-characters Using `.lstrip()` with multi-character strings is misleading

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
strip-with-multi-characters	30	15	15	0	0

[ntBre]

Is this related to an open issue? Changing the range of a rule is almost always a breaking change because it changes where suppression comments work. I have to think about it a bit more, but this does look like an improvement to me. However, we need to make it a preview change, again because it can break suppression comments.

[Viicos]

I didn't know this would be considered breaking. As such, I opened #27085.

[ntBre]

Thanks! This seems like a pretty clear improvement to me, we just need to make it a preview change, as I mentioned before.

[ntBre]

Thank you!